319481 - Make tree/menu icons always appear 16x16 (favicons wrong size in places view)

Status: RESOLVED DUPLICATE of bug 364316

(Firefox :: Bookmarks & History, defect, P4)

Description

[Brett Wilson]

When the favicon is 32x32, it is cropped in treeviews instead of resized.

see bug 175787

Comment 1

[Phil Ringnalda (:philor)]

*** Bug 327367 has been marked as a duplicate of this bug. ***

Comment 2

[Dave Townsend [:mossop]]

*** Bug 328189 has been marked as a duplicate of this bug. ***

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Modifying summary to help prevent further dupes

Comment 4

[Brett Wilson]

*** Bug 331141 has been marked as a duplicate of this bug. ***

Comment 5

[Brett Wilson]

Overview: Currently, the tree view displays images using the CSS list-style-image attribute. This syntax does not have any way of expressing desired size for scaling.

For this bug, we'll have to enhance the CSS syntax for expressing list-style-image-size or something. Then implement this in the treeview.

Comment 6

[Phil Ringnalda (:philor)]

*** Bug 333258 has been marked as a duplicate of this bug. ***

Comment 7

[Liz Looney]

Bug 175787 is now fixed in the trunk.

All that needs to be done to fix this bug is to modify places.css and add the following:
treechildren::-moz-tree-image(title) {
  width:16px;
  height:16px;
}

I'm not sure whether to put this in just /browser/components/places/contents.places.css, or in both /browser/themes/pinstripe/browser/places/places.css and /browser/themes/winstripe/browser/places/places.css.

Both themes places.css's currently set both the width and height to 0px. I don't know why.

Comment 8

[Liz Looney]

Ben asked me to assign this bug to him.

Comment 9

[Tracy Walker [:tracy]]

should bug 340411 be a dupe of this.  It has oversized favicons like bug 331141, which was duped to this.  just don't want the oversized favicons to get lost in cropped favicons.

Comment 10

[Brett Wilson]

(In reply to comment #9)
> should bug 340411 be a dupe of this.

No, this bug is only for tree views.

Comment 11

[Brett Wilson]

(In reply to comment #10)
> (In reply to comment #9)
> > should bug 340411 be a dupe of this.
> 
> No, this bug is only for tree views.

Well, the title actually says for "menus" as well, so I guess I'm wrong.

Comment 12

[Tracy Walker [:tracy]]

*** Bug 340411 has been marked as a duplicate of this bug. ***

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv